Skip to content

feat: bridge V3 discovery response properties to React Native#852

Merged
wvanhaevre merged 2 commits into
developfrom
devin/1782121628-bridge-v3-discovery-properties
Jun 30, 2026
Merged

feat: bridge V3 discovery response properties to React Native#852
wvanhaevre merged 2 commits into
developfrom
devin/1782121628-bridge-v3-discovery-properties

Conversation

@tvanlaerhoven

@tvanlaerhoven tvanlaerhoven commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary

Exposes missing THEOlive endpoint properties from the native SDKs through the React Native bridge.

New V3 properties (web-only until native SDKs add support):

  • src: string | EndpointMillicastSource — generic source replacing legacy format-specific fields
  • srcType: string — source type discriminator ('hesp', 'hls', 'hlsMpegTs', 'millicast', 'dai')
  • provider: string — endpoint provider (e.g. 'optiview', 'mediakind')
  • distribution: TheoLiveDistribution — inline distribution on the endpoint

Missing legacy properties now bridged on Android + iOS:

  • hlsMpegTsSrc: string — HLS MPEG-TS source URL
  • daiAssetKey: string — DAI asset key

Already bridged on Android, now exposed in TypeScript:

  • targetLatency: number — target latency in seconds (was in EndpointAdapter.kt but missing from TheoLiveEndpoint interface)

Changes

TheoLiveEndpoint interface gains 7 optional properties. Legacy fields are marked @deprecated with migration guidance toward src/srcType.

Android EndpointAdapter.fromEndpoint() now forwards hlsMpegTsSrc and daiAssetKey from the native Endpoint object.

iOS THEOplayerRCTTHEOliveEventAdapter.fromEndpoint() now forwards hlsMpegTsSrc and daiAssetKey from EndpointAPI.

Link to Devin session: https://dolby.devinenterprise.com/sessions/788fe10ebc82492d9276207da6447be8
Requested by: @tvanlaerhoven


Open in Devin Review

Add missing endpoint properties from native SDKs:
- src, srcType, provider, distribution (V3, web-only for now)
- hlsMpegTsSrc, daiAssetKey (backward compat, Android + iOS)
- targetLatency (Android)

Update native bridges to forward hlsMpegTsSrc and daiAssetKey
on both Android (EndpointAdapter.kt) and iOS
(THEOplayerRCTTHEOliveEventAdapter.swift).

Co-Authored-By: tom.vanlaerhoven <tom.vanlaerhoven@dolby.com>
@tvanlaerhoven tvanlaerhoven self-assigned this Jun 22, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

devin-ai-integration[bot]

This comment was marked as resolved.

Comment thread src/api/theolive/TheoLiveEndpoint.ts Outdated
srcType?: string;

/**
* The provider of this endpoint (e.g. 'optiview', 'mediakind').

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace comment with:

The provider of this endpoint (e.g. 'optiview').

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done — updated the provider comment to The provider of this endpoint (e.g. 'optiview').

…r example

Co-Authored-By: tom.vanlaerhoven <tom.vanlaerhoven@dolby.com>
@tvanlaerhoven tvanlaerhoven requested a review from wvanhaevre June 29, 2026 08:40
@tvanlaerhoven tvanlaerhoven marked this pull request as ready for review June 29, 2026 09:59
@wvanhaevre wvanhaevre merged commit ea14ac1 into develop Jun 30, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants