feat: bridge V3 discovery response properties to React Native#852
Merged
wvanhaevre merged 2 commits intoJun 30, 2026
Merged
Conversation
Add missing endpoint properties from native SDKs: - src, srcType, provider, distribution (V3, web-only for now) - hlsMpegTsSrc, daiAssetKey (backward compat, Android + iOS) - targetLatency (Android) Update native bridges to forward hlsMpegTsSrc and daiAssetKey on both Android (EndpointAdapter.kt) and iOS (THEOplayerRCTTHEOliveEventAdapter.swift). Co-Authored-By: tom.vanlaerhoven <tom.vanlaerhoven@dolby.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
tvanlaerhoven
commented
Jun 29, 2026
| srcType?: string; | ||
|
|
||
| /** | ||
| * The provider of this endpoint (e.g. 'optiview', 'mediakind'). |
Member
Author
There was a problem hiding this comment.
Replace comment with:
The provider of this endpoint (e.g. 'optiview').
Contributor
There was a problem hiding this comment.
Done — updated the provider comment to The provider of this endpoint (e.g. 'optiview').
…r example Co-Authored-By: tom.vanlaerhoven <tom.vanlaerhoven@dolby.com>
wvanhaevre
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exposes missing THEOlive endpoint properties from the native SDKs through the React Native bridge.
New V3 properties (web-only until native SDKs add support):
src: string | EndpointMillicastSource— generic source replacing legacy format-specific fieldssrcType: string— source type discriminator ('hesp','hls','hlsMpegTs','millicast','dai')provider: string— endpoint provider (e.g.'optiview','mediakind')distribution: TheoLiveDistribution— inline distribution on the endpointMissing legacy properties now bridged on Android + iOS:
hlsMpegTsSrc: string— HLS MPEG-TS source URLdaiAssetKey: string— DAI asset keyAlready bridged on Android, now exposed in TypeScript:
targetLatency: number— target latency in seconds (was inEndpointAdapter.ktbut missing fromTheoLiveEndpointinterface)Changes
TheoLiveEndpointinterface gains 7 optional properties. Legacy fields are marked@deprecatedwith migration guidance towardsrc/srcType.Android
EndpointAdapter.fromEndpoint()now forwardshlsMpegTsSrcanddaiAssetKeyfrom the nativeEndpointobject.iOS
THEOplayerRCTTHEOliveEventAdapter.fromEndpoint()now forwardshlsMpegTsSrcanddaiAssetKeyfromEndpointAPI.Link to Devin session: https://dolby.devinenterprise.com/sessions/788fe10ebc82492d9276207da6447be8
Requested by: @tvanlaerhoven